2.x: improve performance of Observable.flatMapIterable #4612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 78.10% (diff: 83.92%)@@ 2.x #4612 diff @@
==========================================
Files 553 554 +1
Lines 36128 36182 +54
Methods 0 0
Messages 0 0
Branches 5559 5564 +5
==========================================
+ Hits 28231 28261 +30
- Misses 5891 5909 +18
- Partials 2006 2012 +6
|
JakeWharton
approved these changes
Sep 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performance of
flatMapIterableby inlining the consumption of the generatedIterable. The performance improvement comes from direct iteration and emission plus removing the overhead of the regularflatMapas such source mappings are inherently synchronous.Benchmark
i7 4790, Windows 7 x64, Java 8u102, JMH 1.13, ops/s - bigger is better
10x overhead reduction in flattening a single element
Iterable.Half the overhead compared to (an already optimized)
Flowable.flatMapIterable.Nice improvement on the cross-range benchmark (stream 1 million element split into N outer and M inner elements where N * M = 1 million):
Also quite better than
Flowable.flatMapIterable.